AG-1471, AG-1473, AG-1474: add workflow to create agora/data Docker image and run end-to-end tests #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallieswan
commented
Jun 5, 2024
Comment on lines
+79
to
+80
| port, | ||
| reuseExistingServer: true, |
There was a problem hiding this comment.
Reuse the existing server rather than having playwright start the server for us
hallieswan
commented
Jun 5, 2024
| ); | ||
| let dbUser: string | undefined; | ||
| let dbPass: string | undefined; | ||
| if (process.env.APP_ENV === 'e2e') { |
There was a problem hiding this comment.
Get credentials from environment variables when running e2e tests
…ve access to secrets
hallieswan
force-pushed
the
AG-1471_AG-1473_AG-1474
branch
from
97739dd to
7e28125
Compare
hallieswan
commented
Jun 6, 2024
Comment on lines
+7
to
+9
| # Run in Sage repo on develop or main branches | ||
| # and on all branches in user-owned forks | ||
| if: ${{ github.ref_name == 'develop' || github.ref_name == 'main' || github.actor == github.repository_owner }} |
There was a problem hiding this comment.
Forks do not have access to the Sage repo's secrets, so don't run this workflow in the Sage repo on pull_request trigger. Instead, run the workflow when there is a push to develop/main or when the user pushes to a repo that they own (i.e. their forked repo).
|
Looks great! |
sagely1
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the workflow builds the agora/data image on the runner and then runs the e2e tests. In a future PR, we'll split this workflow into three jobs:
Note: we will need to add the appropriate environment variables and secrets to this repository before the workflow will run.